On Fri, 12 Dec 2025 19:25:14 GMT, Coleen Phillimore <[email protected]> wrote:
> EnableValhalla is a property that determines the answer to > safe_to_read_header(), so I think it should go there. I don't see EnableValhalla as something that determines the answer to safe_to_read_header(). Rather, we only need to check safe_to_read_header() if Valhalla is enabled. I think it's clearer to show at the call site that this is a Valhalla-specific concern, since checking if the header is safe to read or not isn't relevant otherwise. I'll go ahead and add a comment to the current version of safe_to_read_header(). ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1785#discussion_r2618752202
