On Mon, 15 Dec 2025 19:51:28 GMT, Dan Heidinga <[email protected]> wrote:
>> I started to write a comment but they end up being something like: >> >> // Make sure that the caller does not accidentally ignore the return value >> >> >> which is sort-of what [[nodiscard]] means, so I'm not sure this is a good >> comment. >> >> Maybe something talking about why it is important to not forget to check the >> return value: >> >> The caller is responsible to throw an exception on failure >> >> >> WDYT? > >> The caller is responsible to throw an exception on failure > > That would be perfect! Thanks I added the last sentence but I'm a little bit uncertain about the grammar. Feel free to nit-pick if it sounds weird. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1792#discussion_r2620924424
