On Wed, 17 Dec 2025 17:19:09 GMT, Matias Saavedra Silva <[email protected]> 
wrote:

>> CDS heap dumping was manually disabled in lworld due to the method in which 
>> the migrated value classes were added to the JDK. Migrated value classes 
>> were added through module patching which is incompatible with CDS heap 
>> dumping, but now since they are added through jimage, we can re-enable CDS 
>> heap dumping and related features that rely on it.
>> 
>> AOT adds some complexity to this as it loads and links classes in VM 
>> startup, so alternate code paths need to be considered. Signature calling 
>> conventions are stored in adapters which are archived in the AOT code cache, 
>> but they aren't usable at runtime, so they need to be regenerated even if we 
>> don't regenerate the adapters.
>
> Matias Saavedra Silva has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Un-problem listed test

LGTM

-------------

Marked as reviewed by fparain (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/1757#pullrequestreview-3589267519

Reply via email to