On Fri, 19 Dec 2025 09:46:28 GMT, Tobias Hartmann <[email protected]> wrote:
>> Marc Chevalier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review
>
> src/hotspot/share/ci/ciFlatArray.cpp line 47:
>
>> 45: }
>> 46:
>> 47: ciConstant ciFlatArray::check_constant_null_marker_cache(int off) {
>
> Do we really need a cache here?
Maybe? I read
https://github.com/openjdk/valhalla/blob/69399cedf6fe208832a66c134d370af860154bc2/src/hotspot/share/ci/ciObject.hpp#L62-L63
and
https://github.com/openjdk/valhalla/blob/69399cedf6fe208832a66c134d370af860154bc2/src/hotspot/share/ci/ciObject.cpp#L173-L175
It seems to be more a correctness thing than a performance matter. It couldn't
see why I wouldn't have a similar risk.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1826#discussion_r2634882449
