On Mon, 19 Jan 2026 12:08:04 GMT, Quan Anh Mai <[email protected]> wrote:
> Hi, > > There are numerous tests of which verifiers assert that the hash value of 2 > objects are equal to verify that those objects are equal. As `acmp` has > become more mature, this PR updates those to verify that 2 objects are equal. > This is more straightforward and it produces a nicer debug message in case of > failures. I changed the order of some asserts that are changed or nearby. > This is because the argument order of assert is `(expected, actual)`, and the > assertion message would be `expected: ..., but was: ...`, so changing the > order to the correct one gives us a more intuitive message. > > A side effect of this PR is that it helps reproduce > [JDK-8372824](https://bugs.openjdk.org/browse/JDK-8372824) in a consistent > manner with `-XX:+UnlockExperimentalVMOptions -XX:PerMethodSpecTrapLimit=0 > -XX:PerMethodTrapLimit=0`. > > Please take a look and leave your reviews, thanks a lot. This pull request has now been integrated. Changeset: 4c6f9021 Author: Quan Anh Mai <[email protected]> URL: https://git.openjdk.org/valhalla/commit/4c6f902108bdede867574fbdda53da66ea2cb363 Stats: 332 lines in 11 files changed: 10 ins; 24 del; 298 mod 8375602: [lworld] Test verifiers should verify the equivalence of the objects if possible Reviewed-by: thartmann ------------- PR: https://git.openjdk.org/valhalla/pull/1929
