On Tue, 20 Jan 2026 19:17:48 GMT, Vicente Romero <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Review, various cleanup >> - Merge branch 'bworld' of https://github.com/openjdk/valhalla into >> feature/cf-bang-sig >> - Classfile signature bang support > > src/java.base/share/classes/java/lang/classfile/Signature.java line 277: > >> 275: @Override >> 276: default ClassTypeSig nullUnmarked() { >> 277: return nullMarker(NullMarker.UNMARKED); > > question: why not using the same terminology as used in javac: > > CHECKED == NOT_NULL > UNMARKED == UNSPECIFIED? Done. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1933#discussion_r2710177032
