On Mon, 2 Feb 2026 09:27:33 GMT, Joel Sikström <[email protected]> wrote:
>> Hello, >> >> Right now it's not clear that the dummy field that is injected into empty >> inline klasses can be/is reused for the null-marker when looking at the >> printed layout from -XX:+PrintInlineLayout. I suggest we enhance this print >> to indicate if the dummy field has been reused for the null-marker. >> >> I've tested that the added comment in the print is there when nullability is >> turned on (default), and not there when turned off >> (`-XX:-UseNullableValueFlattening -XX:-UseNullableNonAtomicValueFlattening`). >> >> >> Before: >> Instance fields: >> @0 RESERVED 12/- >> @12 REGULAR 1/1 ".empty" B >> >> After: >> Instance fields: >> @0 RESERVED 12/- >> @12 REGULAR 1/1 ".empty" B (reused as null-marker) >> >> >> Testing: >> * GHA >> * Oracle's tier1 > > Joel Sikström has updated the pull request incrementally with one additional > commit since the last revision: > > no dummy field in static layout printing Thank you for the reviews everyone! I reran tier1-2 on the tip of lworld, which is green. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2001#issuecomment-3845930895
