On Wed, 4 Feb 2026 13:42:22 GMT, Quan Anh Mai <[email protected]> wrote:
>> Hi, >> >> The issue is that we blindly assume that the vararg argument is a not flat >> and not null-free array. This misses 2 factors: >> >> - With the introduction of nullable flat layouts, it is possible to flatten >> a default array allocation (e.g. `new Integer[4]`) >> - The node may have its own speculative type already, we need to make sure >> our optimistic guess does not contradict the existing speculation. >> >> As a result, I changed the implementation to assume that the exact type is >> the default refined type of the declared parameter type. >> >> Testing: >> >> - [ ] tier1-4,valhalla-comp-stress, Linux-x64 >> >> Please kindly review, thanks a lot. > > Quan Anh Mai has updated the pull request incrementally with one additional > commit since the last revision: > > comments Thanks, the new comment looks good! ------------- Marked as reviewed by thartmann (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2030#pullrequestreview-3751154175
