When adding compiler replay, I've tried to only emit the additional information 
value class array properties at replay dump time when we are actually dealing 
with value classes (i.e. `Arguments::is_valhalla_enabled()` is true). However, 
this sets an unwanted restriction: When the replay file was created with 
`--enable-preview` but replay compilation runs without `--enable-preview` (or 
vice versa), we run into problems. 
[JDK-8377657](https://bugs.openjdk.org/browse/JDK-8377657) tried to fix this 
but created new problems. I therefore suggest to just unconditionally emit the 
array properties, even though they would currently not be used in mainline.

The `ciReplay` tests all passed with and without `--enable-preview` locally.

Thanks,
Christian

-------------

Commit messages:
 - 8377792: [lworld] compiler/ciReplay/TestLambdas.java fails

Changes: https://git.openjdk.org/valhalla/pull/2088/files
  Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=2088&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8377792
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/valhalla/pull/2088.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2088/head:pull/2088

PR: https://git.openjdk.org/valhalla/pull/2088

Reply via email to