On Thu, 12 Feb 2026 10:14:08 GMT, Paul Hübner <[email protected]> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ioi comment and additional testing
>
> test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedFlatArrayApp.java
> line 34:
>
>> 32: public static class ArchivedData {
>> 33: Integer[] intArray;
>> 34: CharPair[] charPairArray;
>
> From a high-level perspective, would it be valuable to additionally also test
> the following?
> 1. Null-free layouts, doesn't necessarily have to be 8 byte payloads, I think
> re-using `CharPair` and parameterizing the below test should be fine.
> 2. Scenarios where we flatten during archival but not at runtime or
> vice-versa (controlled by our flattening flag). I'm not sure if this would
> even work, but it feels like it'd be a good sanity test.
Based on offline conversations, the test cases you proposed go beyond the scope
of JEP 401 and would be only temporary test cases.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2081#discussion_r2799720577
