On Mon, 16 Feb 2026 08:57:22 GMT, Aleksey Shipilev <[email protected]> wrote:
>>> This code doesn't change so the merge with valhalla would be zero if it was >>> 4 bytecodes per line. >> >> I am confused to what this means? >> This code must change with Valhalla as it adds two new internal bytecodes >> `fast_vgetfield` and `fast_vputfield`. > > Yeah, please keep the table formatting intact. For one thing, it obscures > what you are semantically changing in the table? I understand it would be > uglier, but that's OK. To be clear, do you want the table to be like this change (which includes alignment fixes and comment fixes): https://github.com/openjdk/valhalla/pull/2068/changes/59c1fc2e7dedd079a61dced4401267dace7c642d Or do you have some other formatting in mind? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2811388639
