On Wed, 18 Feb 2026 08:09:07 GMT, Marc Chevalier <[email protected]> wrote:
>> This is a redo of #2116. >> >> This PR makes the necessary changes to also make the inline entry point >> fields in the nmethod class a `uint16_t` like JDK-8329433 did for the other >> entry points. Importantly, this PR preserves the default values necessary >> for unused entry points. >> >> Testing: >> - [ ] tier1,tier2,tier3 > > src/hotspot/share/code/nmethod.cpp line 1454: > >> 1452: }; >> 1453: >> 1454: _osr_entry_point = >> relocate_address(nm._osr_entry_point); > > It becomes unclear whether it's worth having this lambda. I don't think it > has other usage. It is heavy as a C++ lambda, it gives a name... No strong > opinion. Feel free to ignore. Good catch! It would be more useful if we defined it in the header and then use it to define the `*entry_point` methods corresponding to the `*entry_offset` fields in terms of it. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2123#discussion_r2820994882
