On Wed, 18 Feb 2026 16:15:03 GMT, Marc Chevalier <[email protected]> wrote:

>> Patricio Chilano Mateo has updated the pull request with a new target base 
>> due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Review comments
>>  - Merge branch 'lworld' into JDK-8377714
>>  - v1
>
> src/hotspot/cpu/aarch64/continuationHelper_aarch64.inline.hpp line 132:
> 
>> 130:     log_trace(continuations)("real_frame_size is addr is " 
>> INTPTR_FORMAT, p2i(real_frame_size_addr));
>> 131:     return (address*)(f.unextended_sp() + 
>> (*real_frame_size_addr/wordSize) + 1);
>> 132:   } else {
> 
> Why `compiled_frame_details()` can't be used here? I probably don't 
> understand what this method does. At first glance, it looks like it's 
> `sender_pc_addr`, but I imagine there is something subtle going on.
> 
> Of course, the same question applies to the x64 version of it.

Yes, it can be used. Changed.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2085#discussion_r2830796008

Reply via email to