On Fri, 20 Feb 2026 08:35:44 GMT, Christian Hagedorn <[email protected]> wrote:
> When merging in [JDK-8373343](https://bugs.openjdk.org/browse/JDK-8373343), > we adapted the code to handle an additional verification case for Valhalla > specific `AddP` shapes (`case #10`). It was wrongly assumed that when a `Phi` > is present, it must be this new case. However, `case #3` could also contain a > phi as seen in `is_captured_store_address()`: > > https://github.com/openjdk/valhalla/blob/ae263e906af1e94bd07c6786c190816e9c104e17/src/hotspot/share/opto/escape.cpp#L3940-L3958 > > I propose to revert back to the original assert and just additionally add a > check for `case #10`. > > Thanks, > Christian Looks good to me. Thanks for helping with the merge and quickly fixing this! ------------- Marked as reviewed by thartmann (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2144#pullrequestreview-3830796157
