On Fri, 20 Feb 2026 08:54:48 GMT, Axel Boldt-Christmas <[email protected]> 
wrote:

> PS: I see this code in Serial and G1, but not sure where to find it in 
> Parallel if it exists.

I missed this, fixed now.

For the broader discussion on visiting element klass, in this PR, I just went 
with matching what happens with the case where we do not split arrays.

> src/hotspot/share/oops/flatArrayKlass.inline.hpp line 51:
> 
>> 49:   precond(contains_oops());
>> 50:   precond(start >= 0);
>> 51:   assert(start <=  end, "Invalid range [%d - %d)", start, end);
> 
> Suggestion:
> 
>   assert(start <= end, "Invalid range [%d - %d)", start, end);

`InlineKlass::oop_iterate_specialized` thought there might be push-back on 
delegating to `oop_oop_iterate_elements_specialized_bounded` instead of looping 
and directly using `InlineKlass::oop_iterate_specialized` in 
`oop_oop_iterate_elements_specialized`. If no push-back, then I can remove 
`InlineKlass::oop_iterate_specialized`

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2142#discussion_r2833031280
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2142#discussion_r2833038575

Reply via email to