On Thu, 19 Feb 2026 12:22:57 GMT, Benoît Maillard <[email protected]> wrote:
> This PR addresses several missed optimizations linked to `InlineType` nodes. > These failures were originally caught during testing in > `compiler/valhalla/inlinetypes/TestArrays.java` and > `compiler/valhalla/inlinetypes/TestNullableInlineTypes.java`. I noticed there > were two distinct cases in these tests and extracted reproducers. > > The first case is a missed notification in `add_users_of_use_to_worklist` > when we have nested `InlineType` nodes and we want to use the base oop if > fields are loaded from memory. Since the structure might be nested, we need > to add all the users in a recursive fashion. > > The other case happens when we call `InlineTypeNode::buffer` during parsing. > In `InlineTypeNode::Ideal`, we search re-allocation of an inlintype and > attempt to remove them. Since this optimization hides behind the > `can_reshape` flag, we need to make sure that the node gets added to the > worklist after calling `PhaseGVN::transform`. > > ### Testing > - [x] GitHub Actions > - [x] tier1-3, plus some internal testing > > Thank you for reviewing! This pull request has now been integrated. Changeset: 7b3ac63d Author: Benoît Maillard <[email protected]> Committer: Tobias Hartmann <[email protected]> URL: https://git.openjdk.org/valhalla/commit/7b3ac63d269acc338a9e7b2fb680e023c0455dfb Stats: 194 lines in 5 files changed: 181 ins; 0 del; 13 mod 8376778: [lworld] Ideal verification fails with "Need to remove from hash before changing edges" for various tests Reviewed-by: thartmann ------------- PR: https://git.openjdk.org/valhalla/pull/2135
