On Tue, 24 Feb 2026 08:57:09 GMT, Alan Bateman <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review feedback > > test/jdk/jdk/internal/jrtfs/JrtFileSystemClassParityTest.java line 41: > >> 39: * @test id=normal >> 40: * @summary Ensures the default runtime JRT file system has identical >> behavior >> 41: * in packaged or exploded builds compared to >> Class.getResourceAsStream(). > > The summary on ClassResourcesParityTest is clear that it tests the contents > of class resources locates with jrtfs vs. Class.getResources. > > The comment on JrtFileSystemClassParityTest is still a bit confusing (to me) > as the test doesn't compare images vs. exploded build, instead it tests the > mapping of jrt file paths to resources by ensuring that jrt and > Class.getResourceAsStream get the same class bytes. So I think we should > update this summary too, or maybe the two tests should be combined as they do > overlap. Sorry, that was the test I renamed. For some reason it hadn't deleted the old one. Only ClassResourcesParityTest should be there now. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2032#discussion_r2845805164
