On Wed, 25 Feb 2026 14:09:53 GMT, Quan Anh Mai <[email protected]> wrote:
>> Hi, >> >> I find it is a common occurrence that we want to expand a `SafePointNode` >> into a subgraph, and to do that we may need to create a `JVMState` >> ourselves, which may easily results in cumbersome errors because the kit >> state is not created properly. I tried using `GraphKit` to expand generate >> code after a `SafePointNode` (in particular, I tried to emit an uncommon >> trap there), which leads to this PR which consolidates the creation of a >> `GraphKit` from a `SafePointNode` that we want to use its debug state. >> >> Please take a look and leave your reviews, thanks a lot. > > Quan Anh Mai has updated the pull request incrementally with one additional > commit since the last revision: > > only add to the worklist with igvn Okay, looks good. ------------- Marked as reviewed by thartmann (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2163#pullrequestreview-3854581280
