On Tue, 24 Feb 2026 14:16:38 GMT, Casper Norrbin <[email protected]> wrote:
> Hi everyone,
>
> `ClassFileParser::verify_legal_class_name` has some leftover code referencing
> `CONSTANT_CLASS_DESCRIPTORS`, which is no longer used and relevant. With the
> code in place, we wrongly verifies classnames, resulting in test failures.
>
> With this PR I have removed all references to `CONSTANT_CLASS_DESCRIPTORS`.
> The failing test now passes as expected and as such I have also removed it
> from the problemlist.
>
> Testing:
> - Tiers 1-3
src/hotspot/share/classfile/classFileParser.cpp line 5003:
> 5001: legal = (p != nullptr) && ((p - bytes) == (int)length);
> 5002: }
> 5003: } else if (_class_name->starts_with("jdk/internal/reflect/") &&
> bytes[length - 1] == ';' ) {
Interesting, this old stub from pre JEP 416 can be nuked. Created
https://bugs.openjdk.org/browse/JDK-8378697 to track this.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2158#discussion_r2853709199
