On Fri, 27 Feb 2026 11:37:12 GMT, David Beaumont <[email protected]> wrote:

> Adds a new AnnotationProcessor to read the @MigratedValueClass on prospective 
> value classes and generate the equivalent source file with the 'value' 
> keyword at each annotated class declaration.
> 
> This adds new PROCESSOR_PATH variable to the compilation macro and use it for 
> annotation processing.
> This also requires moving the plugin discovery path to the new variable (was 
> in classpath before) because the addition of a '--processor-path' flag 
> disables using the classpath for plugin discovery.
> 
> For now this is all limited to `java.base` but that's expandable later 
> easily. There was an issue just enabling it for all modules however (esp. 
> `jdk.incubator` which might be special).
> 
> While there is currently no specific unit test for this code, if it were to 
> fail to generate the correct value classes, a lot of other downstream tests 
> would fail.

make/modules/java.base/Gensrc.gmk line 40:

> 38: include gensrc/GensrcRegex.gmk
> 39: include gensrc/GensrcScopedMemoryAccess.gmk
> 40: include gensrc/GensrcValueClasses.gmk

Let's remove this gmk file too.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2180#discussion_r2863990815

Reply via email to