On Wed, 18 Feb 2026 18:45:22 GMT, Frederic Parain <[email protected]> wrote:

>> Joel Sikström has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Add assert to check for invalid flags/bits
>>  - Change type to be consistent with compiler type
>
> This is a very nice encapsulation of ArrayProperties. However, I'm wondering 
> if the transformation could go one step further and make ArrayProperties 
> instances immutable, because after their creation, there's no reason to 
> change the set of properties of the array. This would prevent accidental 
> modifications of the property set. It would also allow the creation of a 
> static instance for the "default" set of properties independent from the 
> constructors.

Thank you for the reviews @fparain @Arraying! I reran tier1-4 which is green. 
The GHA failure is unrelated.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2114#issuecomment-3973517532

Reply via email to