On Fri, 27 Feb 2026 18:45:27 GMT, David Beaumont <[email protected]> wrote:
>> Adds a new AnnotationProcessor to read the @MigratedValueClass on >> prospective value classes and generate the equivalent source file with the >> 'value' keyword at each annotated class declaration. >> >> This adds new PROCESSOR_PATH variable to the compilation macro and use it >> for annotation processing. >> This also requires moving the plugin discovery path to the new variable (was >> in classpath before) because the addition of a '--processor-path' flag >> disables using the classpath for plugin discovery. >> >> For now this is all limited to `java.base` but that's expandable later >> easily. There was an issue just enabling it for all modules however (esp. >> `jdk.incubator` which might be special). >> >> While there is currently no specific unit test for this code, if it were to >> fail to generate the correct value classes, a lot of other downstream tests >> would fail. > > David Beaumont has updated the pull request incrementally with one additional > commit since the last revision: > > More tests and tidying This is now tested and passes. Obviously there's a question of how to access the annotation processor *for* testing "legitimately", but I think the tests are valuable enough to want to keep in one way or another. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2180#issuecomment-3974503045
