On Sat, 28 Feb 2026 05:21:55 GMT, Chris Plummer <[email protected]> wrote:
>> TestScaffold uses test arguments as additional options for debuggee process. >> Options like `-XX:+PrintInlineLayout', `-XX:+PrintFlatArrayLayout` can >> cause significant debuggee output before TestScaffold connect to the >> debuggee and start to read it output. As a result internal output buffer >> fills and debuggee process hungs. >> The fix removes extra arguments used for experiments at test development. > > test/jdk/com/sun/jdi/valhalla/FieldWatchpointsTest.java line 32: > >> 30: * @run main/othervm FieldWatchpointsTest >> 31: * -XX:+UseArrayFlattening -XX:+UseFieldFlattening >> -XX:+UseAtomicValueFlattening -XX:+UseNullableValueFlattening >> 32: * -XX:+UnlockDiagnosticVMOptions >> -XX:+PrintInlineLayout -XX:+PrintFlatArrayLayout > > Do we really need to get rid of all of the options? Aren't > `-XX:+PrintInlineLayout` and `-XX:+PrintFlatArrayLayout` the main culprits? All this `Use..Flattening` options are `true` by default now. It's better to use default values so it can be set by job arguments ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2184#discussion_r2874480967
