On Tue, 3 Mar 2026 07:10:27 GMT, David Holmes <[email protected]> wrote:
> The message wasn't being copied into the array, nor was the array being used.
> Converted to a simpler stringStream usage.
>
> Added a regression test to the existing monitor tests.
>
> Thanks
Looks good and test makes sense. Thanks.
test/hotspot/jtreg/runtime/valhalla/inlinetypes/MonitorEnterTest.java line 81:
> 79: // Attempts to lock the instance are repeated many time to ensure
> that the different paths
> 80: // are used: interpreter, C1, and C2 (which deopt to the
> interpreter in this case)
> 81: for (int i = 0; i < 20000; i++) {
Nit: extra whitespace.
-------------
Marked as reviewed by phubner (Committer).
PR Review:
https://git.openjdk.org/valhalla/pull/2191#pullrequestreview-3881444240
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2191#discussion_r2877238952
