On Thu, 5 Mar 2026 12:55:19 GMT, Axel Boldt-Christmas <[email protected]> 
wrote:

>> For `IS_DEST_UNINITIALIZED` it would never be valid for the 
>> CardTableBarrierSet to do a pre-barrier. Currently `value_copy_in_heap` and 
>> `value_store_null_in_heap` both iterates the oops and virtually calls into 
>> the barriers sets pre barriers (of which all implementations are no-ops for 
>> uninitialized values).
>> 
>> Remove this as part of the `CardTableBarrierSet` interface. After this is 
>> integrated I will upstream the relevant changes of this patch to mainline.
>
> Axel Boldt-Christmas has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Update cardTableBarrierSet.inline.hpp
>  - Update cardTableBarrierSet.inline.hpp

Looks good. Thanks.

-------------

Marked as reviewed by stefank (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2200#pullrequestreview-3896988606

Reply via email to