On Fri, 6 Mar 2026 09:14:17 GMT, Stefan Karlsson <[email protected]> wrote:
>> I have a bunch of patches to remove some code duplication, redundant setting >> of fields, unneeded dispatch code. >> >> I've tested this with tier1-3. >> >> I'm opening this up as one PR, depending on #2033, but it could be split up >> into multiple dependent PRs. It could be good to look at each commit >> individually when making a first pass of over this PR. >> >> I'll add a guide to the individual commits as a comment after the summary. > > Stefan Karlsson has updated the pull request incrementally with two > additional commits since the last revision: > > - Restore temporary assert > - Review: more is_refined_objArray usage This looks really good! I think the mainline and this change can be merged easily so can go into both and not need breaking up. src/hotspot/share/oops/arrayKlass.cpp line 116: > 114: > 115: ArrayKlass::ArrayKlass(int n, Symbol* name, KlassKind kind, > ArrayProperties props) > 116: : Klass(kind, calc_prototype_header(kind, props)), Does this prototype header account for the special one for UseCompactObjectHeaders? It didn't before so this looks correct but I think we should always use prototype_header from the Klass unconditionally as a separate RFE. ------------- Marked as reviewed by coleenp (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2117#pullrequestreview-3903765163 PR Review Comment: https://git.openjdk.org/valhalla/pull/2117#discussion_r2895816564
