On Fri, 6 Mar 2026 13:01:27 GMT, Axel Boldt-Christmas <[email protected]> 
wrote:

> Verified that we now can build with ubsan intstrumentation in Valhalla. Have 
> not tested ubsan beyond building `images`.
> 
> Testing
> * GHA

src/hotspot/share/code/vtableStubs.cpp line 269:

> 267:   address vtable_index_addr = vtable_stub_addr + offset_of(VtableStub, 
> _index);
> 268:   bool is_vtable_stub = *vtable_type_addr == 
> static_cast<uint8_t>(VtableStub::Type::vtable_stub);
> 269:   bool caller_is_c1 = *vtable_caller_type_addr == 
> static_cast<uint8_t>(VtableStub::CallerType::c1);

This makes me squint - can you add ()?

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2206#discussion_r2895834991

Reply via email to