I've been looking over the current state of ArrayKlass and the sub-classes and made various cleanups and simplifications that I'd like to get integrated:
* Type Universe::_objectArrayKlass as RefArrayKlass * Remove dead flat array code in code in javaClasses.cpp * Used is_refined_objArray_klass where appropriate * Introduce is_unrefined_objArray for asserts and checks * Restore code and whitespace changes compared to upstream * Renamed faklass to fak in oops/ and GC code (I didn't touch other areas that used that name) * Devirtualized ObjArrayKlass::allocate_instance and simplified related code * Moved ArrayKlass::_properties to after the variables for array dimensions. * Made ArrayKlass::_properties const and non-settable * Unified oop_iterate_elements_range implementations * Added ShouldNotReachHere implementation of ObjArrayKlass::copy_array * Removed redundant check in jniCheck.cpp and restored the file ------------- Commit messages: - Stray whitespaces - Restore jniCheck.cpp - Array cleanups - Retype _objectArrayKlass - allocate_instance - Small cleanups - More type checks - Constify and move around ArrayKlass::_properties - Be explicit about array klass when calling restore_unshareable_info - Restore diff against master Changes: https://git.openjdk.org/valhalla/pull/2207/files Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=2207&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8379514 Stats: 206 lines in 35 files changed: 21 ins; 65 del; 120 mod Patch: https://git.openjdk.org/valhalla/pull/2207.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2207/head:pull/2207 PR: https://git.openjdk.org/valhalla/pull/2207
