On Tue, 10 Mar 2026 12:05:54 GMT, Paul Hübner <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo in probe
>
> src/hotspot/share/prims/jni.cpp line 3180:
>
>> 3178: HOTSPOT_JNI_ISVALUEOBJECT_ENTRY(env, obj);
>> 3179: oop o = JNIHandles::resolve(obj);
>> 3180: if (o != nullptr && o->klass()->is_inline_klass()) {
>
> What should the semantics of `ISVALUEOBJECT` be for abstract value classes?
> These are instance klasses. The more conventional way to check is the absence
> of `ACC_IDENTITY`, and from that one can decide whether to check for
> concreteness or if identityless is sufficient.
On second thought, we get the klass via `obj` so it should be instantiated and
concrete. This should be fine.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2203#discussion_r2911358349
