On Wed, 11 Mar 2026 13:08:09 GMT, Frederic Parain <[email protected]> wrote:
>> test/hotspot/jtreg/runtime/valhalla/inlinetypes/field_layout/ValueComparisonTest.java
>> line 90:
>>
>>> 88: Path tempWorkDir;
>>> 89: try {
>>> 90: tempWorkDir = Files.createTempDirectory(currentDir,
>>> "generatedClasses_" + seed);
>>
>> Sorry, I gave you the wrong name in the earlier comment. I meant `Utils` not
>> `Path`.
>> Use this instead:
>> https://github.com/openjdk/valhalla/blob/432870d43a3ef3ffb181e5909454af58754febc9/test/lib/jdk/test/lib/Utils.java#L808
>
> This code and the one in Utils.java are equivalent. The tests have been
> updated to use jdk/lib/Utils code for the sake of integration with JTREG.
> FYI, most tests in the runtime directory still use
> Files.createTemp[Directory|File] instead of the jdk/lib/Utils version.
We should migrate to Utils, I believe there is an effort in mainline for this.
Thanks for changing!
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2202#discussion_r2918480146
