On Fri, 13 Mar 2026 12:43:41 GMT, Paul Hübner <[email protected]> wrote:
>> test/hotspot/jtreg/runtime/valhalla/inlinetypes/field_layout/ValueRandomLayoutTest.java
>> line 82:
>>
>>> 80: public static void main(String[] args) throws Exception {
>>> 81: String seedProperty = "CLASS_GENERATION_SEED";
>>> 82: String seedString = System.getProperty(seedProperty);
>>
>> We have `jdk.test.lib.Utils` which have a generalised concept for this.
>>
>> `Utils.getRandomInstance();`
>>
>> https://github.com/openjdk/valhalla/blob/5de772acbc9e63d22ac24a1c633ffd59e319a50b/test/lib/jdk/test/lib/Utils.java#L513-L526
>
> That would look nicer. Would you be okay with it being a follow-up RFE?
Sure, was more a drive-by comment. I have not looked at the ValueClassGenerator
at all.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2223#discussion_r2931038226
