On Tue, 10 Mar 2026 11:59:06 GMT, Paul Hübner <[email protected]> wrote:
>> Hi all,
>>
>> This adds some more debug prints to various internals.
>>
>> When printing an `InstanceKlass`, the kind is now shown. For example:
>>
>> InstanceKlass (kind=1): java.lang.Integer {0x00001ff00022c318}
>>
>>
>> The `InlineKlass::Members` are also printed. For example (note that to get
>> individual array entries `WizardMode` must be enabled):
>>
>> - ---- inline type members:
>> - extended signature registers: Array<T>(0x00000001330002f8)
>> 0 : SigEntry: type=18 offset=0 null_marker=0 Symbol: 'java/lang/Integer'
>> count 65535
>> 1 : SigEntry: type=10 offset=16 null_marker=0 Symbol: 'value' count 65535
>> 2 : SigEntry: type=14 offset=24 null_marker=0 Symbol: 'java/lang/Integer'
>> count 65535
>> - return registers: Array<T>(0x0000000133000348)
>> 0 : (c_rarg0,c_rarg0)
>> 1 : (c_rarg7,BAD!)
>> - pack handler: 0x0000000119b21238
>> - pack handler (jobject): 0x0000000119b21140
>> - unpack handler: 0x0000000119b21244
>> - null reset offset: 128
>> - payload offset: 16
>> - payload size (bytes): 8
>> - payload alignment: 8
>> - null-free non-atomic size (bytes): 4
>> - null-free non-atomic alignment: 4
>> - null-free atomic size (bytes): 4
>> - nullable atomic size (bytes): 8
>> - nullable non-atomic size (bytes): 5
>> - null marker offset: 20
>>
>>
>> Fields now indicate their field flags. Non-static fields indicate (a) when
>> they are flat and (b) their layout when flat. For example:
>>
>> - ---- non-static fields (1 words):
>> - private final value flat 'inner' (fields 0x00000006) 'LAValue;' @12
>> LayoutKind: NULLABLE_NON_ATOMIC_FLAT
>>
>>
>> Arrays already have plenty of flattening information that can be printed.
>>
>> Testing: tiers 1-3.
>
> Paul Hübner has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove commented out line.
Looks good to me, with the recommendation to fix JDK-8380129 a soon as possible
to prevent confusion for people looking at the new output.
-------------
Marked as reviewed by fparain (Committer).
PR Review:
https://git.openjdk.org/valhalla/pull/2208#pullrequestreview-3956028949
