On Thu, 19 Mar 2026 12:01:44 GMT, Benoît Maillard <[email protected]> wrote:
>> This PR prevents hitting an assert in `vframeArrayElement::fill_in` when >> escape analysis and autobox elimination are disabled. >> >> With value classes, scalarization can take place independently of escape >> analysis. When deoptimizing, this implies that we must always rematerialize >> objects when `EliminateAllocations` is true, even if escape analysis is >> disabled. >> Prior to this change, we hit an assert in `vframeArrayElement::fill_in` >> because it is expected that scalarized objects are already reallocated >> there. We have to make sure that `rematerialize_objects` is run before that. >> >> ### Testing >> - [x] tier1-3, plus some internal testing, with `-XX:-DoEscapeAnalysis >> -XX:-EliminateAutoBox` >> >> Thank you for reviewing! > > Benoît Maillard has updated the pull request incrementally with one > additional commit since the last revision: > > Add minimal reproducer I like this version better. ------------- Marked as reviewed by mchevalier (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2240#pullrequestreview-3974630109
