On Wed, 18 Mar 2026 17:03:27 GMT, Benoît Maillard <[email protected]> wrote:

> The link between the root cause of this issue and how it gets reported as a 
> missing optimization opportunity is quite subtle.

Thanks for the disclaimer! That reminds me of 
https://github.com/openjdk/jdk/pull/28331

The explanation sounds like it makes sense, but I'll need to think deeper to be 
sure.

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestMissingOptCastSpeculative.java
 line 74:

> 72:             iload(2).
> 73:             aconst_null().
> 74:             aastore().

If I understand well, it's doing `va[index] = null` and it's expected to throw? 
Maybe worth adding a little comment for people who don't enjoy assemblies as 
much as I do?

-------------

PR Review: 
https://git.openjdk.org/valhalla/pull/2242#pullrequestreview-3981794893
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2242#discussion_r2966001788

Reply via email to