> Hi, > > SA does not support value objects. The tests should be disabled when running > with `--enable-preview`. Currently, all SA tests use `@requires vm.hasSA`. > > Extending `vm.hasSA` to require non-preview automagically skips all of the > relevant tests. > > Testing on Linux (x64, AArch64), macOS (x64, AArch64), Windows x64: > * tier 1 sanity test > * `:hotspot_serviceability` (most of the SA tests), with and without preview > * `:hotspot_resourcehogs` (some SA tests), with and without preview > * `:svc_tools` (some `jhsdb` tests), with and without preview
Paul Hübner has updated the pull request incrementally with two additional commits since the last revision: - Add tests to the problem list. - Revert "Constrain hasSA to non-preview configurations." This reverts commit 7bdfce0b642447580ad3da2c4d7fb3abd95a9a8c. ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/2236/files - new: https://git.openjdk.org/valhalla/pull/2236/files/7bdfce0b..9fd6dda3 Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2236&range=01 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2236&range=00-01 Stats: 15 lines in 3 files changed: 10 ins; 2 del; 3 mod Patch: https://git.openjdk.org/valhalla/pull/2236.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2236/head:pull/2236 PR: https://git.openjdk.org/valhalla/pull/2236
