On Mon, 23 Mar 2026 19:43:40 GMT, Frederic Parain <[email protected]> wrote:
>> Paul Hübner has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Fix test failure. >> - Experimentalize some flattening flags. >> - Diagnosticize compiler flag. >> - Adjust level of flattening flags. >> - Revert "Rename PrintInlineLayout to PrintValueLayout." >> >> This reverts commit 382ea88fb72144fce00e51d6fc3274d604b60cd7. >> - Revert "Rename InlineTypeX to ValueTypeX." >> >> This reverts commit 768fd170564bbf24686b4277888ffdb46a5195e8. > > src/hotspot/share/runtime/globals.hpp line 844: > >> 842: "Allow the JVM to flatten some null-free atomic values") >> \ >> 843: >> \ >> 844: product(bool, UseNullableNonAtomicValueFlattening, true, >> EXPERIMENTAL, \ > > I'd put this flag in the DIAGNOSTIC category instead of EXPERIMENTAL, because > it is used for value fields inside value objects (all non-static fields of a > value class are strict and final). Thanks, fixed. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2226#discussion_r2983336027
