On Thu, 26 Mar 2026 19:30:55 GMT, Chen Liang <[email protected]> wrote:
>> make/modules/java.base/gensrc/GensrcVarHandles.gmk line 69: >> >>> 67: # Only plain access for non-atomic storage >>> 68: $1_KEYS += NonPlainAccess >>> 69: endif >> >> Should the `ifeq` be `ifneq` since I think you are testing for the presence >> of NonAtomic stuff here? >> >> The comment on L67 doesn't match the code on L68: `# Only plain access` >> versus `+= NonPlainAccess`. > > Yep, that's a typo in my template. I should renme this prop to nonatomic. Not really, this is `ifeq` means everyone except NonAtomicXxx have NonPlainAccess. I have clarified the comments here. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2265#discussion_r2997279832
