On Mon, 30 Mar 2026 11:15:34 GMT, Tobias Hartmann <[email protected]> wrote:

> Similar to [JDK-8380802](https://bugs.openjdk.org/browse/JDK-8380802) / 
> https://github.com/openjdk/valhalla/pull/2258, larval bit handling should be 
> removed from C2. I also added a missing `Arguments::is_valhalla_enabled()` 
> check to `LoadNode::Value`.
> 
> Thanks,
> Tobias

src/hotspot/share/opto/callnode.cpp line 2035:

> 2033:     mark_node = LoadNode::make(*phase, control, mem, proto_adr, 
> phase->type(proto_adr)->is_ptr(), TypeX_X, TypeX_X->basic_type(), 
> MemNode::unordered);
> 2034:   } else {
> 2035:     // For now only enable fast locking for non-array types

This comment is from mainline and somehow got lost in Valhalla.

src/hotspot/share/opto/runtime.cpp line 326:

> 324:     // Scavenge and allocate an instance.
> 325:     Handle holder(current, klass->klass_holder()); // keep the klass 
> alive
> 326:     oop result = InstanceKlass::cast(klass)->allocate_instance(THREAD);

Changed this back to mainline code.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2275#discussion_r3009140317
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2275#discussion_r3009137496

Reply via email to