On Mon, 30 Mar 2026 14:32:15 GMT, Frederic Parain <[email protected]> wrote:

> Small test fix in the value class generator which sometimes fails to 
> recognize two set of arguments are equals because of classes supporting 
> duplicates in their predefined values set. When generating the constructor 
> arguments, the code now generates two strings, one with the arguments to be 
> used in the generated source file, and another one containing only the 
> arguments of types not allowing duplicates to be used as a unique ID.
> 
> Tested locally with the seeds causing failures in the CI.
> 
> Thanks,
> 
> Fred

Looks fine, thank you.

-------------

Marked as reviewed by phubner (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2278#pullrequestreview-4035709337

Reply via email to