On Thu, 2 Apr 2026 01:50:51 GMT, Bill Huang <[email protected]> wrote:
>> The idea is to implement the **ValueClass** annotation that can be used in >> test code to allow to run the same tests with and without --enable-preview. >> >> This annotation should be used to mark value classes. >> >> The new jtreg test compilation and execution mode that uses javac plugin to >> process classes during compilation. This plugin change classes with >> **ValueClass** annotation to value classes. >> By default, the annotation doesn't have any impact on the tests. >> >> Here are the work items: >> >> 1. Create ValueClass annotation. >> 2. Create a javac plugin, ValueClassPlugin, that implements a TaskListener >> to mark a class as a value class during the PARSE phase. >> 3. Build the ValueClass plugin. >> 4. Pass a new plugin option, -Xplugin:ValueClassPlugin, to enable the plugin >> and enable preview. > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > Remove unused JTREG_VALUE_CLASS_ANNOTATION_JAR and guard the -cpa: plugin > JAR option behind JTREG_VALUE_CLASS_PLUGIN to avoid adding it to the > classpath when the plugin is not active. Looks good. Thank you for addressing all feedback! ------------- Marked as reviewed by lmesnik (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2253#pullrequestreview-4047919360
