On Thu, 9 Apr 2026 12:35:30 GMT, Paul Hübner <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update markWord.hpp > > src/hotspot/share/oops/markWord.hpp line 122: > >> 120: >> 121: // Number of bits >> 122: static const int lock_bits = 2; > > I know we already discussed this offline and the comment is helpful, but as > an alternative if we want to be really clear we could opt for `_n_bits`. I > don't feel super strongly about this, it's moreso a comment for your > consideration. Thanks. FWIW, we used to name things `n<something>` in the ZGC code, but then decided in the Oracle GC team to replace all those with `num_<something>`. If we feel strongly about renaming these, I would prefer that we do so in openjdk/jdk. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2310#discussion_r3057949397
