On Thu, 7 May 2026 05:25:39 GMT, Axel Boldt-Christmas <[email protected]> wrote:
> When doing `# Setup compilation for preview classes in the module` a comma is > missing after `EXCLUDE_FILES`. So instead of setting > `<module>-preview_KEEP_ALL_TRANSLATIONS := value` it is added as to the > `<module>-preview_EXCLUDE_FILES` variable. > > > <module>-preview_EXCLUDE_FILES := $(EXCLUDE_FILES) KEEP_ALL_TRANSLATIONS := > $(KEEP_ALL_TRANSLATIONS) > > > Instead of > > <module>-preview_EXCLUDE_FILES := $(EXCLUDE_FILES) > <module>-preview_KEEP_ALL_TRANSLATIONS := $(KEEP_ALL_TRANSLATIONS) > > > The only usage of this variable set to true is in `jdk.localedata`, which is > probably why it went unnoticed. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Marked as reviewed by liach (Committer). ------------- PR Review: https://git.openjdk.org/valhalla/pull/2398#pullrequestreview-4242609010
