On Thu, 7 May 2026 18:46:10 GMT, Chris Plummer <[email protected]> wrote:
> Update JDI and JDWP specs for Valhalla. There are no functional changes with > this PR, just clarification in the spec on expected behavior when using value > objects in a few places. Note there were earlier changes in JVMTI that > resulted in JDWP and JDI conforming to the spec changes related to debugging > during value object construction. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This all seems reasonable to me. But the primary approval is the eventual CSR of course. src/jdk.jdi/share/classes/com/sun/jdi/StackFrame.java line 107: > 105: * {@link ObjectReference} returned will be for a snapshot > of the > 106: * value object, not a reference to the actual value object > under > 107: * construction. Therefore the ObjectReference returned > will not reflect Suggestion: * construction. Therefore the ObjectReference returned will not reflect Extra space ------------- Marked as reviewed by dholmes (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2411#pullrequestreview-4247885117 PR Review Comment: https://git.openjdk.org/valhalla/pull/2411#discussion_r3204830767
