On Thu, 7 May 2026 22:51:22 GMT, Dan Smith <[email protected]> wrote:
>> Two changes: >> >> - Remove the `Class.isIdentity` method, which is redundant given the >> `Class.isValue` method >> - Clean up `Class.isValue` so that it only returns true for value classes, >> not other non-identity things (interfaces, primitives) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Dan Smith has updated the pull request incrementally with one additional > commit since the last revision: > > compare-and-set checks don't need to look at field type I think this is the right behavior for `isValue` to only report `true` for abstract and concrete value classes. I have no opinion on whether `isValue` or `isIdentity` is better. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2397#issuecomment-4401813281
