On Fri, 8 May 2026 01:54:09 GMT, David Holmes <[email protected]> wrote:
>> Joel Sikström has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust comment
>
> src/hotspot/share/utilities/exceptions.cpp line 478:
>
>> 476: }
>> 477:
>> 478: void Exceptions::wrap_exception_in_internal_error(const char* message,
>> JavaThread* THREAD) {
>
> Nit: we use `THREAD` when we need it for the macros e.g.
> `HAS_PENDING_EXCEPTION`. If the code doesn't use the macros then it could
> just be `JavaThread* current`. Though arguably we should be using TRAPS as
> this can throw. I realize `wrap_dynamic_exception` set the precedent for this
> formulation though, so not insisting on any changes.
Yeah I agree with you. I tried to be consistent with `wrap_dynamic_exception`
(except for the comments which aren now fixed). I'll take a note of this and
maybe revisit this in mainline post-integration.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2410#discussion_r3206964026
