> The problem is that we are pushing casts through InlineTypeNodes without 
> checking if their types are even compatible. In dead parts of the graph, when 
> a type check wasn't folded yet, the type of the CheckCastPP can be completely 
> unrelated to the type of the InlineTypeNode. Pushing the cast through leads 
> to an incorrect type being used further below in the graph and subsequent 
> failures.
> 
> I tried hard to come up with standalone reproducer for this but failed. It 
> reproduces reliably with replay compilation though.
> 
> Thanks,
> Tobias
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Tobias Hartmann has updated the pull request incrementally with one additional 
commit since the last revision:

  Fixed check

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2423/files
  - new: https://git.openjdk.org/valhalla/pull/2423/files/afb0bd05..57d5ca92

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2423&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2423&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/valhalla/pull/2423.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2423/head:pull/2423

PR: https://git.openjdk.org/valhalla/pull/2423

Reply via email to