On Wed, 13 May 2026 13:27:59 GMT, Quan Anh Mai <[email protected]> wrote:
>> Tobias Hartmann has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments and test fix
>
> src/hotspot/share/opto/inlinetypenode.cpp line 232:
>
>> 230: assert(!field->is_flat() || field->type()->is_inlinetype(), "must be
>> an inline type");
>> 231:
>> 232: if (!recursive || !field->is_flat() || value->is_top()) {
>
> This looks a bit cluttered, can we move `if (value->is_top())` into a
> separate case before this `if` instead?
Sure. I had this version first but didn't like it but I don't have a strong
opinion. Updated.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2433#discussion_r3234958902
