On Wed, 20 May 2026 13:30:43 GMT, Nir Lisker <[email protected]> wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make UInt64::lessThan public
>
> src/java.base/share/classes/java/math/UInt128.java line 313:
>
>> 311: return parse(s, i, end, i, 2, '_', -1);
>> 312: }
>> 313: return parse(s, begin, end, i, 8, '_', c);
>
> This can be a pattern matching switch:
>
> return switch (lc) {
> case 'x' -> parse(s, i, end, i, 16, '_', -1);
> case 'b' -> parse(s, i, end, i, 2, '_', -1);
> default -> parse(s, begin, end, i, 8, '_', c;
> };
Indeed.
Maybe in a followup PR.
Thanks
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2420#discussion_r3274926810