On Wed, 20 May 2026 21:53:07 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> This patch adds detailed printing for flat arrays in the AOTMapLogger and >> allows proper printing of embedded oops. Verified with tie 1-5 tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request incrementally with one > additional commit since the last revision: > > Added copyright src/hotspot/share/cds/aotMapLogger.cpp line 642: > 640: cast_to_oop(value_addr), // _raw_oop > 641: k, // _klass > 642: 0, // _size Need a comment here -- why size can be zero? src/hotspot/share/cds/aotMapLogger.cpp line 711: > 709: } > 710: > 711: // Create a wrapper for an archivd flat array element archivd -> archived test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedFlatArrayTest.java line 37: > 35: * > ArchivedFlatArrayApp$ArchivedData > 36: * > ArchivedFlatArrayApp$CharPair > 37: * > ArchivedFlatArrayApp$Wrapper Need to fix indent. Why did the test work before this change? Has this test been excluded? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2444#discussion_r3278559196 PR Review Comment: https://git.openjdk.org/valhalla/pull/2444#discussion_r3278556627 PR Review Comment: https://git.openjdk.org/valhalla/pull/2444#discussion_r3278565581
