On Fri, 22 May 2026 08:09:33 GMT, Roland Westrelin <[email protected]> wrote:

> A dying substitutability call is transformed during igvn but the
> current logic fails to detect it's dead.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestDeadSubstitutabilityCallInIdeal.java
 line 29:

> 27:  * @enablePreview
> 28:  * @run main/othervm -Xcomp -XX:CompileOnly=${test.main.class}::test* 
> -XX:CompileCommand=dontinline,${test.main.class}::notInlined
> 29:  *                   -XX:+StressIGVN -XX:StressSeed=2677332830 
> ${test.main.class}

Suggestion:

 *                   -XX:+UnlockDiagnosticVMOptions -XX:+StressIGVN 
-XX:StressSeed=2677332830 ${test.main.class}

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestDeadSubstitutabilityCallInIdeal.java
 line 31:

> 29:  *                   -XX:+StressIGVN -XX:StressSeed=2677332830 
> ${test.main.class}
> 30:  * @run main/othervm -Xcomp -XX:CompileOnly=${test.main.class}::test* 
> -XX:CompileCommand=dontinline,${test.main.class}::notInlined
> 31:  *                   -XX:+StressIGVN ${test.main.class}

Suggestion:

 *                   -XX:+UnlockDiagnosticVMOptions -XX:+StressIGVN 
${test.main.class}

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestDeadSubstitutabilityCallInIdeal.java
 line 34:

> 32:  * @run main/othervm -Xcomp -XX:CompileOnly=${test.main.class}::test* 
> -XX:CompileCommand=dontinline,${test.main.class}::notInlined
> 33:  *                   ${test.main.class}
> 34:  */

Error: VM option 'StressIGVN' is diagnostic and must be enabled via 
-XX:+UnlockDiagnosticVMOptions.
Error: The unlock option must precede 'StressIGVN'.
Improperly specified VM option 'StressIGVN'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2467#discussion_r3287306157
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2467#discussion_r3287306838
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2467#discussion_r3287307637

Reply via email to